Allow user deactivation on the Synapse side to take longer than 30s #4471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `connect_timeout` plus `timeout` are enough to handle general network issues
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
d7791db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://26c1e38a.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-synapse-slow-deacti.matrix-authentication-service-docs.pages.dev |
sandhose
added
the
T-Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On m.org, deactivations take more than 30s, meaning that we see deactivation jobs failing quite often. It's fine because they retry, but it would be better if they actually don't fail.
This removes the global 30s 'read timeout' on HTTP requests, as the
connect_timeoutandtimeoutare already enough